Skip to content

objcopy: copy file, section, and symbol flags#163

Merged
philipc merged 4 commits intogimli-rs:masterfrom
philipc:comdat
Dec 17, 2019
Merged

objcopy: copy file, section, and symbol flags#163
philipc merged 4 commits intogimli-rs:masterfrom
philipc:comdat

Conversation

@philipc
Copy link
Contributor

@philipc philipc commented Dec 14, 2019

Also a couple of COFF write fixes.

Fixes #159, fixes #160

WIP: there's probably more non-COFF flags that still need to be copied, but probably worth testing if it really does fix #159, cc @jayvdb

@philipc
Copy link
Contributor Author

philipc commented Dec 15, 2019

Updated to handle more ELF/Mach-O flags (e.g. you can set RWX sections for ELF now).

@philipc philipc marked this pull request as ready for review December 15, 2019 07:16
@philipc philipc merged commit f31c374 into gimli-rs:master Dec 17, 2019
@philipc philipc deleted the comdat branch December 17, 2019 02:47
@jayvdb
Copy link
Contributor

jayvdb commented Dec 19, 2019

I'll test it this weekend.

@jayvdb
Copy link
Contributor

jayvdb commented Dec 22, 2019

#159 is fixed, both __real@.. and "string'" (??_C@...`, in the linking side of things. I haven't run the Python test suites yet to stress test the resulting binaries, but with this fix I have bigger fish to fry and the hacks in indygreg/PyOxidizer#192 are no longer needed. Thanks so much.

mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
objcopy: copy file, section, and symbol flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

objcopy should preserve more format-specific attributes coff write causes multiply defined __real@3ff0000000000000

2 participants